Fix complete order factory to have non-pending inventory units #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an order is completed, all its inventory units are by default set to `pending: false`. The factory should reflect that. This made a change to the shipment spec necessary. That spec is setup with a completed order, and then runs `Spree::Shipment#finalize`, which is run at order completion, so I manually reset the inventory unit to pending.
mamhoff
force-pushed
the
fix-completed-order-factories
branch
from
4fb7018 to
e48c921
Compare
tvdeyen
approved these changes
Mar 27, 2017
jhawthorn
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an order is completed, all its inventory units are by default
set to
pending: false. The factory should reflect that.