Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider pending inventory units cancelable #1800

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 27, 2017

Before an order is complete, all its inventory units are marked as "pending". Once
the order passes the complete step, the inventory units' pending attribute is
set to false.

Item cancelations were designed for completed orders only, as before that, one could
just change inventory on line items. Therefore, we should not consider pending inventory
units as cancelable.

@mamhoff mamhoff force-pushed the fix-inventory-units-cancelable-scope branch from b070c88 to 55331c7 Compare March 27, 2017 15:19
@mamhoff
Copy link
Contributor Author

mamhoff commented Mar 27, 2017

Once #1787 is in, this will be green. I'll rebase then rather than create a merge conflict.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before an order is complete, all its inventory units are marked as "pending". Once
the order passes the `complete` step, the inventory units' `pending` attribute is
set to false.

Item cancelations were designed for completed orders only, as before that, one could
just change inventory on line items. Therefore, we should not consider pending inventory
units as cancelable.
@mamhoff mamhoff force-pushed the fix-inventory-units-cancelable-scope branch from 55331c7 to beab2f3 Compare March 31, 2017 09:46
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jhawthorn jhawthorn merged commit b0dc0cc into solidusio:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants