Fix outstanding balance calculation with refunds #1835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For more detailed explanation see: #1475 (comment) |
Created a spec to simulate the behavior listed in solidusio#1475 in order to properly fix the issue.
payment_total includes all refunds on the payments as well so there is no reason to recalculate that in #outstanding_balance
ericsaupe
force-pushed
the
fix-outstanding-balance
branch
from
840c0a4 to
7d5ea37
Compare
Based on the regression test added in solidusio#1926 this change fixes that spec by including refund_total in outstanding_balance calculation if the order has not been canceled.
ericsaupe
force-pushed
the
fix-outstanding-balance
branch
from
7d5ea37 to
a198895
Compare
|
@jhawthorn updated with your regression test from #1926 |
|
Thanks Eric and Taylor. Closing in favour of #2002, which includes the specs from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payment_total includes all refunds on the payments as well so there
is no reason to recalculate that in #outstanding_balance
Fixes #1475