Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for refund outstanding_balance #1926

Merged

Conversation

jhawthorn
Copy link
Contributor

No description provided.

jhawthorn added 2 commits May 22, 2017 02:32
The value in the DB should already be human readable, this just ruins
capitalization.
@jhawthorn
Copy link
Contributor Author

jhawthorn commented May 22, 2017

When run with #1835, this errors with

-:outstanding_balance => 0,
-:payment_state => "paid",
-:payment_total => 100,
-:refund_total => 10,
-:total => 110,
+:outstanding_balance => 10,
+:payment_state => "balance_due",
+:payment_total => 100,
+:refund_total => 10,
+:total => 110,

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gmacdougall gmacdougall merged commit ed9c20b into solidusio:master May 23, 2017
ericsaupe added a commit to deseretbook/solidus that referenced this pull request Jun 5, 2017
Based on the regression test added in solidusio#1926 this change fixes
that spec by including refund_total in outstanding_balance
calculation if the order has not been canceled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants