Remove custom responders #1956
Remove custom responders #1956
Conversation
|
Let's merge this once the extension has been moved to the |
|
@mamhoff I don't think we need to push to solidus-contrib if we push it to rubygems. if anyone ever runs across that extension, its not like we want them to use it. |
|
@cbrunsdon Sure, as long as people can use the extension from their Gemfile somehow, this is good to go. |
Custom responders and customized respond_with are being removed to an extension
harmonymjb
force-pushed
the
remove-custom-responders
branch
from
772fb8c to
4f86fa8
Compare
|
@cbrunsdon @mamhoff I think it would be best if this was on solidus-contrib, I would like to see the tests run on TravisCI |
|
Yeah, I like seeing tests run, too. @cbrunsdon Would you be happy with a note saying: "This gem is deprecated, don't use"? |
CHANGELOG.md
Outdated
| @@ -78,6 +78,8 @@ | |||
| - Emit Spree.url JS deprecation warning in all environments [\#2017](https://github.com/solidusio/solidus/pull/2017) ([jhawthorn](https://github.com/jhawthorn)) | |||
|
|
|||
|
|
|||
| - Customized responders have been removed. They are available in the `solidus_responders` extension | |||
There was a problem hiding this comment.
Could we move this to the 2.4.0 section
harmonymjb
force-pushed
the
remove-custom-responders
branch
from
4f86fa8 to
c0355e6
Compare
|
https://github.com/solidusio-contrib/solidus_responders We've moved the repo to solidus-contrib and added a bold note at the top |
jhawthorn
dismissed
gmacdougall’s stale review
This has been addressed (and Gregor is on vacation)
This PR removes custom responders, in favor of placing them in an extension.
I'm currently hosting the extension on my github here.
This resolves the first part of #1869