Remove spree responders #2083
Closed
Remove spree responders #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
force-pushed
the
remove_responders
branch
from
d47517c to
293b201
Compare
|
Closing this for right now. Learnt what these did and realize I have to kill them harder. |
|
@cbrunsdon also, there's another PR ( #1956 ) for this same task. |
Pull responders out of the project. I don't know what they do and I'm not smart enough to figure it out, so I'm almost positive they aren't used.
|
@kennyadsl oh nice :D. should have looked first. So @omnistegan how is #1956 looking? (also I'm looking at you right now, when you're curious about why I'm staring at you later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull responders out of the project.
I don't know what they do and I'm not smart enough to figure it out, so
I'm almost positive they aren't used.