Deprecate support for alternate Kaminari page_method_name #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically this looks like it is to support kaminari and will_paginate side-by-side, which doesn't seem like a reasonable thing for us to care about inside of core. Anyone that wanted this functionality can use it inside their own app. Also it wasn't tested.
gmacdougall
approved these changes
Jul 26, 2017
jhawthorn
approved these changes
Jul 27, 2017
jhawthorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically this looks like it is to support kaminari and will_paginate
side-by-side, which doesn't seem like a reasonable thing for us to care
about inside of core.
Anyone that wanted this functionality can use it inside their own app.
Also it wasn't tested.
Came from: spree/spree#5035