Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for alternate Kaminari page_method_name #2115

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Deprecate support for alternate Kaminari page_method_name #2115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/app/models/spree/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ def self.preference(*args)

if Kaminari.config.page_method_name != :page
def self.page(num)
Spree::Deprecation.warn \
"Redefining Spree::Base.page for a different kaminari page name is better done inside " \
"your own app. This will be removed from future versions of solidus."

send Kaminari.config.page_method_name, num
end
end
Expand Down