Remove extra set_current_order calls (updated CHANGELOG and rebase) #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this is calling on almost every request in the front end. We want to push this to where it should be which is just when we sign in authentication systems.
|
Thanks a lot! |
kennyadsl
approved these changes
Aug 24, 2017
acreilly
pushed a commit
to acreilly/solidus_auth_devise
that referenced
this pull request
Jan 4, 2019
The specs against Solidus master are failing because `set_current_order` is not defined as a process_action callback. This used to be the case but Solidus has removed this and slated it for v2.4. For compatibility with older versions of Solidus, we should not raise an ArgumentError if this callback is not defined but still skip it if it is. PR removing this callback: solidusio/solidus#2185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases and updates the CHANGELOG entry for @Murph33's #1137.
In the CHANGELOG entry I've included what the "current enough version" of solidus_auth_devise is (the
set_current_ordercall was added in v1.5.0. I've also included the issue it addressed.Original PR
Currently this is calling on almost every request in the front end. We
want to push this to where it should be which is just when we sign in
authentication systems.