Stop raising an exception when callback in UsersController is undefined #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewart
approved these changes
Sep 12, 2017
|
I noticed a small typo in the commit message. That was my change after Andrew's approval. |
|
In thinking about this a bit more, this solution may be incomplete, as we need to support older versions of Solidus, which will still have |
The specs against Solidus master are failing because `set_current_order` is not defined as a process_action callback. This used to be the case but Solidus has removed this and slated it for v2.4. For compatibility with older versions of Solidus, we should not raise an ArgumentError if this callback is not defined but still skip it if it is. PR removing this callback: solidusio/solidus#2185
|
I've made an update adding |
swcraig
changed the title
skip_before_action of undefined callback
stewart
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs are failing because
set_current_orderis not defined as aprocess_action callback. This used to be the case but then it was
removed from Solidus.
PR removing this callback:
solidusio/solidus#2185