use class instead data-hook for gateway partial #2212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
requested changes
Oct 5, 2017
| @@ -1,9 +1,9 @@ | |||
| <%= image_tag 'credit_cards/credit_card.gif', id: 'credit-card-image' %> | |||
| <% param_prefix = "payment_source[#{payment_method.id}]" %> | |||
|
|
|||
| <p class="field"> | |||
| <p class="field" data-hook="card_name"> | |||
There was a problem hiding this comment.
I think the general feeling is to remove data-hook attributes. To follow this path you could use a class instead, like:
<p class="field payment-form-card-name">
and add a similar class to the other elements for consistency (number and expiration).
You should be able to hook this element with a class as well, right?
There was a problem hiding this comment.
Yeah, there shouldn't be a problem.
I'm going to update the elements to use class.
ccarruitero
force-pushed
the
gateway_partial
branch
from
34b644e to
5b75804
Compare
ccarruitero
changed the title
|
@ccarruitero Can you please rebase this? |
|
@ccarruitero ping 🙂 |
4 tasks
|
Closing now that #3182 was merged, thanks @ccarruitero! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that other fields in the partial have a data-hook and class to allow easy customization, I think will be good that
card namefield have the same