Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classes alongside data-hook attributes for gateway partial #3182

Merged
merged 1 commit into from
May 20, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Apr 16, 2019

Description

Given that other fields in the aforementioned partial have data-hook attributes and classes to allow easy customization, I think it could be good that card-related fields have the same structure

Rebased version of #2212, all the credit goes to @ccarruitero

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok adding a class for card_name but I'd not remove existing data-hook.

@aitbw
Copy link
Contributor Author

aitbw commented Apr 17, 2019

Done @kennyadsl ✔️ I don't know if it's necessary to squash the commits and/or change the PR's title, let me know what you think

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer it if you would squash the commits, but otherwise looks good to me. 👍

@kennyadsl
Copy link
Member

I'd also go for squashing commits, thanks @aitbw!

@aitbw aitbw force-pushed the gateway_partial branch from 31ec921 to 280fd79 Compare April 24, 2019 12:00
@aitbw aitbw changed the title Use classes instead of data-hook attributes for gateway partial Use classes alongside data-hook attributes for gateway partial Apr 24, 2019
@aitbw
Copy link
Contributor Author

aitbw commented Apr 24, 2019

@kennyadsl @jacobherrington squashed!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with adding css classes, but not with adding new data-hook attributes.

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this as it is. Thanks!

@tvdeyen tvdeyen merged commit ba905a7 into solidusio:master May 20, 2019
@aitbw aitbw deleted the gateway_partial branch May 20, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants