-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use classes alongside data-hook attributes for gateway partial #3182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok adding a class for card_name
but I'd not remove existing data-hook
.
Done @kennyadsl ✔️ I don't know if it's necessary to squash the commits and/or change the PR's title, let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer it if you would squash the commits, but otherwise looks good to me. 👍
I'd also go for squashing commits, thanks @aitbw! |
@kennyadsl @jacobherrington squashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with adding css classes, but not with adding new data-hook
attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this as it is. Thanks!
Description
Given that other fields in the aforementioned partial have
data-hook
attributes and classes to allow easy customization, I think it could be good that card-related fields have the same structureRebased version of #2212, all the credit goes to @ccarruitero
Checklist: