Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add static guides site generator #2706

Closed
wants to merge 6 commits into from

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 18, 2018

Add a static guides site generator

We have so many great guides written by @benjaminwil (Thanks Buddy!).

Although it is possible to read the guides in the GitHub interface, I think it's time now to add a static site generator that makes it possible to read the guides in a nicer way.

Why VuePress?

I chose VuePress as static site generator, because it is build solely for the purpose of serving technical docs, fast and feature rich:

  1. Build in search
  2. Easy customizable default theme or build your own theme
  3. "Edit this page" links for easy contribution to guides
  4. Easily deployable to GitHub pages
  5. Run locally for writing guides is very easy

The best thing is that it's served as static site and then turned into a SPA powered by Vue.js

How to run this locally

cd guides 
yarn install
yarn run vuepress dev .

That's it \o/

Demo

https://tvdeyen.github.io/solidus/

Some screenshots

guidelines 2018-04-20 09-26-00

guidelines develop solidus 2018-04-20 09-26-29

@peterberkenbosch
Copy link
Contributor

This is awesome!

Copy link
Contributor

@peterberkenbosch peterberkenbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 18, 2018

@peterberkenbosch Bedankt, Peter! I added an online demo https://tvdeyen.github.io/solidus/

@peterberkenbosch
Copy link
Contributor

Nice @tvdeyen! Static sites are sooooo fast too

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment to keep the root of the project untouched and avoid confusion. I'm pro everything that improve the current documentation status. IMO when we'll have something better we could change this, that is better than having nothing.

Thanks!

package.json Outdated
"devDependencies": {
"vuepress": "^0.6.0"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about moving this into /guide? I just don't want to confuse devs that see this package.json in the root and maybe expect to be able to build something useful for solidus development? I think that the yarn commands can be run into that folder directly as well, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first take, but something led me to move this into the root folder. I will try again, because I agree that this should not be in the root folder.

@tvdeyen tvdeyen force-pushed the vuepress-docs branch 3 times, most recently from 16d607d to 85fc0d4 Compare April 20, 2018 07:09
@tvdeyen tvdeyen force-pushed the vuepress-docs branch 2 times, most recently from bac48d2 to 274fbdb Compare April 20, 2018 07:22
@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 20, 2018

@kennyadsl made the requested changes. Working like charm 👍

Also updated the styles to the new colors and fonts from the shiny new marketing site.

@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 20, 2018

Extracted the fixes for guide files into #2709

@kennyadsl
Copy link
Member

What about also updating the description of this PR with instructions?

It should be:

cd guides 
yarn install
yarn run vuepress dev .

@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 20, 2018

@kennyadsl thanks, updated

@tvdeyen
Copy link
Member Author

tvdeyen commented May 1, 2018

The stembolt folks were working on a new guides site as well, while working on the shiny new website. I will close this in favor of the other PR coming up soon. Thanks for all the great feedback. We think about migrating the soon-to-be released guides site to VuePress as well.

@tvdeyen tvdeyen closed this May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants