-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Add static guides site generator #2706
Conversation
This is awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterberkenbosch Bedankt, Peter! I added an online demo https://tvdeyen.github.io/solidus/ |
Nice @tvdeyen! Static sites are sooooo fast too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a comment to keep the root of the project untouched and avoid confusion. I'm pro everything that improve the current documentation status. IMO when we'll have something better we could change this, that is better than having nothing.
Thanks!
package.json
Outdated
"devDependencies": { | ||
"vuepress": "^0.6.0" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about moving this into /guide
? I just don't want to confuse devs that see this package.json
in the root and maybe expect to be able to build something useful for solidus development? I think that the yarn commands can be run into that folder directly as well, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my first take, but something led me to move this into the root folder. I will try again, because I agree that this should not be in the root folder.
16d607d
to
85fc0d4
Compare
bac48d2
to
274fbdb
Compare
@kennyadsl made the requested changes. Working like charm 👍 Also updated the styles to the new colors and fonts from the shiny new marketing site. |
Extracted the fixes for guide files into #2709 |
What about also updating the description of this PR with instructions? It should be:
|
@kennyadsl thanks, updated |
The stembolt folks were working on a new guides site as well, while working on the shiny new website. I will close this in favor of the other PR coming up soon. Thanks for all the great feedback. We think about migrating the soon-to-be released guides site to VuePress as well. |
Add a static guides site generator
We have so many great guides written by @benjaminwil (Thanks Buddy!).
Although it is possible to read the guides in the GitHub interface, I think it's time now to add a static site generator that makes it possible to read the guides in a nicer way.
Why VuePress?
I chose VuePress as static site generator, because it is build solely for the purpose of serving technical docs, fast and feature rich:
The best thing is that it's served as static site and then turned into a SPA powered by Vue.js
How to run this locally
That's it \o/
Demo
https://tvdeyen.github.io/solidus/
Some screenshots