Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guides: Links and syntax fixes #2709

Merged
merged 4 commits into from
Apr 22, 2018
Merged

Guides: Links and syntax fixes #2709

merged 4 commits into from
Apr 22, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 20, 2018

While working on #2706 I also made some fixes to the guides it self:

  • Fix broken link in orders overview guide
  • Fix links to payment methods guide
  • Add missing ruby syntax to countries & states guide
  • Change the markdown shell syntax to bash

@tvdeyen tvdeyen mentioned this pull request Apr 20, 2018
Closed
kennyadsl
kennyadsl approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gmacdougall
gmacdougall approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas!

@gmacdougall gmacdougall merged commit 00d148c into solidusio:master Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwil benjaminwil benjaminwil approved these changes

@gmacdougall gmacdougall gmacdougall approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvdeyen @kennyadsl @gmacdougall @benjaminwil