-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CODE_OF_CONDUCT.md #2895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 100% support this. ❤️
We need to be sure that reports get dealt with in an appropriate manner. Therefore we would ideally define a person (or several persons) who are in charge for dealing with violations of the CoC.
CODE_OF_CONDUCT.md
Outdated
|
||
## 9. Contact info | ||
|
||
contact@solidus.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know who reads this Mail. We need to make sure we have a public email address that core team members get. Maybe we can define one dedicated person for this and present their email here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, also the contact email and the reporting email should be different.
I'm happy to be that person if no one wants to volunteer, but would a group email for the core team members be better? That would allow you and the others to discuss the emails during core team meetings when/if they came up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to be that person if no one wants to volunteer
Thank you. That would be great.
to discuss the emails during core team meetings
I am not sure this is necessarily a core team responsibility. Reading the code of conduct:
Unacceptable behavior from any community member, including sponsors and those with decision-making authority, will not be tolerated.
Having a team outside of the core team is even preferable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to create something like community@solidus.io?
Please ignore the failed Netlify checks. They will be green after we merged #2893 |
Personally I'm more for a simpler Community Conduct Guideline like the one used for Ruby which we can evolve in our community if we think it's needed. |
@kennyadsl I think that is a good idea. However, I also really like this part of the Citizen Code of Conduct:
And I appreciate the idea of having a line of communication -- such as an email inbox intended for people who are having problems or have questions with the community. Thoughts? |
@tvdeyen @kennyadsl What are your thoughts on the following? The Solidus Code of ConductSolidus strives to be inclusive of as many contributors as possible. All contributors and participants are welcome regardless of gender, sexual orientation, ability, race, ethnicity, socioeconomic status, and religion (or lack thereof). This document highlights the values of the Solidus community. It includes our expectations for community members. It is inspired by elements of the Ruby Community Conduct Guideline. It applies to all "collaborative space", which is defined as community communications channels (such as mailing lists, messaging platforms, conferences, meetups, submitted patches, commit comments, etc.). Community Expectations
We invite all Solidus contributors and participants to join us in creating a productive and positive open source community. Have Questions?I would love to hear from @gmacdougall @cbrunsdon or @ericsaupe as well as any member of the community with opinions on this idea. Thanks. |
Sounds great. Maybe add "Conferences" and "Meetups" as collaborative spaces? |
Done! |
Please rebase to get rid of the Netlify errors. |
ce833be
to
61eed89
Compare
@tvdeyen Done, also updated the CoC to the copy from my previous comment. Thanks! |
Not sure why this failed CI. You can't see any useful information on the Circle web app because of the deprecation warnings, but if you download the log here is the failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Thank you. I think this is a great step forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this is the right direction. I just left some personal opinion on the text proposed. 🙂
@kennyadsl Good suggestions, changes made! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of applying changes from few community members onto this PR without further discussion, we should leave this to the first commit and collect more opinions from the community - especially from outside the core team - and then apply them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is right now, this is not a code of conduct anymore. A code of conduct must have
- a list of unacceptable behaviours
- a rationale for why that list is there
- and an understandable process for a list of infractions.
The document at this point is more a community behaviour guideline ("Let's be nice"). In order to be clear about the intentions of the document, I would request the name of the file to be changed to COMMUNITY_EXPECTATIONS.md
or something along those lines.
Personally, I would prefer a code of conduct with the details listed above. However, that kind of document needs to come with a somewhat institutionalized process about how to deal with infractions (who gets the email, who does not, what action will be taken, etc.). This process needs to be decided from within the core team I think.
@tvdeyen I agree, let's talk about it some more. @mamhoff I think we started with that, but started leaning more towards this based on @kennyadsl's suggestion to look at https://www.ruby-lang.org/en/conduct/ for inspiration. |
According to https://opensource.guide/code-of-conduct/, this draft lacks some points :
I think the the Contributor Covenant is good and used as a base by rails |
I agree with @stem that more should be discussed about what happens if someone violates the code of conduct, where they can go for help, etc.
@ericsaupe @stem that's definitely valuable. Do you have any ideas on how to phrase that? I'd love to incorporate it, but those rules should come from the core team. @tvdeyen any thoughts on how long we should leave this open? I will drop it in Slack again. |
I'm in favour of this change. I know we've had some minor incidents before, having personally assisted in the resolution of some, but there was no official process or rules to govern that, nor expectations laid out. I tend to agree with @mamhoff's points about what's missing here, and with @stem that using the Contributor Covenant is a good option. |
I personally think this is valuable, but I want to open it up to discussion. Going with the Contributor Covenant as a baseline was recommended while discussing different approaches to this type of document.
cf92a12
to
a95294a
Compare
@kennyadsl @tvdeyen @jarednorman @stem @mamhoff Based on suggestions from all of you, I have reset this PR to a single commit that is just the Contributor Covenant. The only part left for this document is selecting an email address to put in this document. Does anyone object to adopting this document, and making changes if the need presents itself? |
@solidusio/core-team I've updated this PR. I still need someone to create an inbox for us to monitor for this kind of thing. Otherwise, I think it's ready to merge. |
I like that the file is not named This is not a legal issue. It's a political issue. The question here is: Do we virtue signal that we'll go slightly out of our way to make people feel welcome who are not white men, or do we not? The document that is now being discussed signals (through omission) that we do not care. Who is in a position to sue anyone, and why would they do that? I have the impression that the framing of the CoC-discussion as "legally difficult", the core team is trying to get out of the political dimension that this has. In my view, this is a political statement, and one that does not help this community attract more contributors (quite the oppposite, as it's making me more reluctant to contribute). It is especially ironic that Github just shipped a feature that allows maintainers to block people in such a way that the blocking is visible. How will the Solidus maintainers use this feature? Under which circumstances? The shipping of that feature also indicates that it is wishful thinking that Github will take care of Solidus' community management. |
Thanks for your insights Martin. GitHub has a team trained to arbitrate and I thik they can do this way better than us. They released that feature but that does not mean that we are forced to use it. They also recently updated their Acceptable Use policy to include restrictions on conduct and they provide a tool to report this kind of abuses, stating:
So I assume they want to take care of violations. |
👍 Also there is this: https://opensource.guide/code-of-conduct/ wanted to add it as reference. It's from GitHub https://github.com/github/opensource.guide. |
Thanks @peterberkenbosch this is a great resource! I agree that we only can adopt a code of conduct if we are also have rules of enforcing it. Otherwise it is worthless. But I also do respect that some people of the core team are not willing to take responsibility of enforcing it. Not everybody that is a great open source maintainer is also a great mediator and trained person to deal with every situation in a correct way. And one can't expect them to be. But I still think we should have a real code of conduct, so what should we do? ProposalLike other communities we form a code fo conduct committee that is not the core team (or at least not all of them). IMO this has several advantages:
Who is willing to join such team? WDYT @solidusio/core-team ? |
@tvdeyen you can write my name down for such a team. No problem. |
Having re-written this like four (or more times) times I agree that we need to delegate this to a small group. I'm happy to help if I'm need, but let's try to balance community/core involvement. Initially I used one of the documents provided by GH, but due to the opinions of this thread, it has transformed into the current state. |
Can we link/import the "Community Guidelines" from https://solidus.io/community-guidelines/ so this can be closed? |
@mamhoff Made a PR for this 👍 |
I personally think this is valuable, but I want to open it up to
discussion. Is this something Solidus would benefit from? Are there
any changes we'd like to make from the Code of Conduct at
http://citizencodeofconduct.org/?
Improvements that could be made to this PR: adding a grievance
policy and adding reporting guidelines.