Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to the community guidelines #3437

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Add links to the community guidelines #3437

merged 1 commit into from
Jan 17, 2020

Conversation

jacobherrington
Copy link
Contributor

Description

We should be able to close #2895 after this is merged.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

mamhoff
mamhoff reviewed Nov 23, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jacobherrington jacobherrington force-pushed the link-to-community-guidelines branch from 77f17fc to b1528b1 Compare November 23, 2019 23:08
spaghetticode
spaghetticode approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobherrington thank you 👍

@jacobherrington jacobherrington merged commit b494770 into solidusio:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff left review comments

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacobherrington @spaghetticode @aldesantis @mamhoff @kennyadsl