Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Api::CouponCodesController#destroy endpoint #3047

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Add Api::CouponCodesController#destroy endpoint #3047

merged 1 commit into from
Jan 24, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Jan 23, 2019

Description

This PR aims to close #1641 by adding a new API endpoint to the CouponCodesController to remove coupon codes from orders.

Said endpoint wasn't added to CouponCodesController under frontend/, but could be added if necessary.

Thanks to @flyfy1, @mtomov, and @loicginoux for their contributions on how to implement this, much appreciated! 🙌 🙇‍♂️

Checklist:

  • Pull Request guidelines are respected
  • Documentation/Readme have been updated accordingly
  • Changes are covered by tests (if possible)
  • Each commit has a meaningful message attached that described WHAT changed, and WHY

kennyadsl
kennyadsl requested changes Jan 23, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks @aitbw !

core/config/locales/en.yml Outdated Show resolved Hide resolved
core/app/models/spree/promotion_handler/coupon.rb Outdated Show resolved Hide resolved
core/app/models/spree/promotion_handler/coupon.rb Outdated Show resolved Hide resolved
@aitbw aitbw force-pushed the aitbw/remove-couponcode-endpoint branch from 340c773 to c34f1dd Compare January 23, 2019 13:01
jacobherrington
jacobherrington reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than my one comment.

core/app/models/spree/promotion_handler/coupon.rb Outdated Show resolved Hide resolved
@aitbw aitbw force-pushed the aitbw/remove-couponcode-endpoint branch from c34f1dd to 25e89a4 Compare January 24, 2019 14:31
jacobherrington
jacobherrington approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aitbw 🍰

@jacobherrington jacobherrington merged commit 375305d into solidusio:master Jan 24, 2019
@kennyadsl
Copy link
Member

Thanks @aitbw !!!! 🎉

@aitbw aitbw deleted the aitbw/remove-couponcode-endpoint branch January 24, 2019 16:32
@aitbw aitbw mentioned this pull request Jan 25, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode left review comments

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Coupon Code?
4 participants
@aitbw @kennyadsl @spaghetticode @jacobherrington