Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for PromotionHandler::Coupon#remove method #3049

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add unit tests for PromotionHandler::Coupon#remove method #3049

merged 1 commit into from
Jan 28, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Jan 25, 2019

Description

As suggested by @spaghetticode, and following #3047, this PR adds unit tests to PromotionHandler::Coupon#remove method to make sure it behaves as expected.

Checklist:

  • Pull Request guidelines are respected
  • Documentation/Readme have been updated accordingly
  • Changes are covered by tests (if possible)
  • Each commit has a meaningful message attached that described WHAT changed, and WHY

kennyadsl
kennyadsl approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

spaghetticode
spaghetticode approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you @aitbw

@aitbw aitbw force-pushed the aitbw/couponcode-remove-tests branch from 2cf8a22 to 67f4c33 Compare January 25, 2019 12:27
jacobherrington
jacobherrington approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kennyadsl kennyadsl merged commit 382967c into solidusio:master Jan 28, 2019
@aitbw aitbw deleted the aitbw/couponcode-remove-tests branch January 28, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aitbw @spaghetticode @kennyadsl @jacobherrington