Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Devise translations #3132

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Mar 4, 2019

Description

This PR completes the original one in #2972 submitted by @afdev82 by rebasing it against current master and removing the commit that introduced I18n normalization.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aitbw Angel Perez
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up @aitbw! 👍

@jacobherrington jacobherrington merged commit f8e5d67 into solidusio:master Mar 5, 2019
@aitbw aitbw deleted the remove_devise_translations branch March 5, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants