Remove devise translations

[afdev82]

This PR remove devise translations, since they are also removed in the solidus_i18n project (see solidusio/solidus_i18n#107) and they are provided by the devise_i18n gem (https://github.com/tigrish/devise-i18n).

[tvdeyen]

Thanks 👏

[kennyadsl]

Thanks!

[jacobherrington]

There is a quite a bit of noise from reformatting here, but it looks okay.

Thanks!

[kennyadsl]

@afdev82 sorry, can you explain better why is the reformatting commit needed?

[afdev82]

@kennyadsl usually the translations are alphabetically ordered and so on "normalized". In this way in both projects (solidus_i18n and solidus) they are in the same place and it's easier to translate them. I would like to add the check for the health of the translations in the ci, in this way every time someone adds a translation it should be in the right place.
At the moment there will be a lot of work to get it working, I tried to check and I have to fine tuning the configuration of the i18n-tasks gem.

[kennyadsl]

usually the translations are alphabetically ordered and so on "normalized".

Got that but shouldn't this be handled by i18n-tasks gem?
What I don't get is why the PR #2963 moved things around and we are reverting some of its changes here?

[afdev82]

Hm... I just run bundle exec i18n-tasks normalize inside the core directory, and then committed the result. And I did this in two commits to make it clearer, if you want we can remove the normalize commit, but it should be fine to always execute this command. If you execute bundle exec i18n-tasks health, it tells you that the translations are not normalized, then I executed that.

[kennyadsl]

Yes but look at this for example. It does the opposite of the normalization happened in this PR, maybe some options changed on you env in the meantime?

[afdev82]

I see... I have to check, I don't know why now.

Need to understand why the extra commit is needed

[jacobherrington]

Let's investigate why bundle exec i18n-tasks normalize displayed different behaviors in this PR and #2963.

I agree we should add the health check to CI to avoid this kind of confusion in the future.

See my above comment.

[kennyadsl]

@afdev82 👋do you have any update here?

[afdev82]

No sorry, I didn't have time to continue on that :(

[kennyadsl]

Reopened as #3132