Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n-tasks and normalize translations #2963

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Nov 21, 2018

This PR adds the i18n-tasks gem to check the translations and reorders them like how is already done in the solidus_i18n project.

In this way it's easier to contribute, because the translations are in the same position.

@afdev82
Copy link
Contributor Author

afdev82 commented Nov 21, 2018

I just run bundle exec i18n-tasks normalize inside the core directory

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl
Copy link
Member

@afdev82 Hey can you please rebase on master since in the meantime some en key changed? I think it could be easier to revert changes and re-run the script at this point since there are a lot of conflicts. Thanks!

@afdev82
Copy link
Contributor Author

afdev82 commented Nov 22, 2018

@kennyadsl yes, I will do it soon ;)

@afdev82
Copy link
Contributor Author

afdev82 commented Nov 22, 2018

maybe you could add bundle exec i18n-tasks health to the ci, we do the same for our projects and it's useful

@tvdeyen
Copy link
Member

tvdeyen commented Nov 22, 2018

maybe you could add bundle exec i18n-tasks health to the ci, we do the same for our projects and it's useful

This is probably a good idea, but I don't know how this will impact the current state of translations. We might want to check the health first, fix all issues and than enable it.

@kennyadsl kennyadsl merged commit a5876d2 into solidusio:master Nov 22, 2018
@kennyadsl
Copy link
Member

Thanks!

@aitbw aitbw mentioned this pull request Dec 5, 2018
@afdev82 afdev82 deleted the reorder_translations branch October 16, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants