Normalize de locales file #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
force-pushed
the
normalize_de_locales
branch
from
c6756e6
to
d8054a2
Compare
I think it's a good idea. We've started something similar in core as well for
Feel free to propose the same solution for Solidus core. 🙂 |
kennyadsl
approved these changes
Jan 31, 2019
jtapia
approved these changes
Mar 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalises German locales file.
I followed the README and decided to update these locales since there are some missing. During this process, the task
i18n-tasks add-missingnormalised my file.I decided to split my work into different PRs and avoid mixing the addition of new translations with the normalisation of the file.
Since the rubocop configuration is set to a maximum length for the line of 140 characters, I configured
i18n-tasksto behave the same during the normalization.I then simply run
i18n-tasks normalizeon the German translations.I think this task should be part of the CI, in order to keep our translations in order (pun intended).
If you also think this is a good thing, I will open a PR to introduce
i18n-tasks check-normalizedin the CI and fix all the other locales.TL;DR;
This PR does not add any translation but just commit the result of
i18n-tasks normalize --locale de