Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align some deprecation messages in Order model #3135

Merged
merged 3 commits into from
May 13, 2019
Merged

Align some deprecation messages in Order model #3135

merged 3 commits into from
May 13, 2019

Conversation

elia
Copy link
Member

@elia elia commented Mar 7, 2019 •
edited
Loading

Description

After update! => recalculate rename.

ref:

❓should create_tax_charge! implementation be replaced with a call to recalculate too?

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@aitbw aitbw mentioned this pull request Mar 13, 2019
Closed
2 tasks
jacobherrington
jacobherrington suggested changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia Can you take a look at the spec failures?

elia added 2 commits May 10, 2019 13:01
@elia
Align deprecation messages
1d1327e 
After update! => recalculate rename.

ref:
- solidusio#1689
- solidusio#2072
@elia
Order#recalculate already updates shipment amounts
0a04e8e 
It does it in the OrderUpdater#update_shipment_amounts.
@elia
Replace create_tax_charge! contents with recalculate
9aa2799 
OrderUpdater already does the same thing within update_taxes.
@elia elia marked this pull request as ready for review May 10, 2019 12:54
@elia
Copy link
Member Author

elia commented May 10, 2019

@jacobherrington fixed, removed the expectation as its already part of order updater:

solidus/core/app/models/spree/order_updater.rb

Lines 138 to 142 in 208febe

def update_shipment_amounts
shipments.each do |shipment|
shipment.update_amounts
end
end

kennyadsl
kennyadsl approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that at this point no one is using those deprecated methods so 👍

ericsaupe
ericsaupe approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl
Copy link
Member

@jacobherrington can you please review again? 🙂

jacobherrington
jacobherrington approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks @elia!

@kennyadsl kennyadsl merged commit 1a4444a into solidusio:master May 13, 2019
@elia elia deleted the patch-1 branch June 4, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elia @kennyadsl @ericsaupe @jacobherrington