Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the API via OpenAPI #3252

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Document the API via OpenAPI #3252

merged 3 commits into from
Jul 10, 2019

Conversation

aldesantis
Copy link
Member

@aldesantis aldesantis commented Jul 4, 2019

Description

Documents our API endpoints using the OpenAPI Specification.

With this format, we have machine-readable API documentation that can be consumed by a number of different tools to generate static HTML documentation, spin up a mock server, validate the documentation against a real API and much more.

Currently, this documentation is managed and hosted on Stoplight. The idea is that we put it in this GitHub repository, then update it whenever the API is changed. A CircleCI job will then copy the documentation to Stoplight and publish a new version of the static documentation when a Solidus version is released. The minor Solidus version (e.g. 2.9) will be used as the Stoplight version.

As a nice bonus, the CircleCI configuration has also been updated to take advantage of 2.1 features such as executors and commands.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@aldesantis aldesantis mentioned this pull request Jul 4, 2019
4 tasks
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Can you please separate the circleci config upgrade from the addition of openapi/stoplight?

openapi/checkout-flow.md Outdated Show resolved Hide resolved
@aldesantis
Copy link
Member Author

@elia commits separated!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @aldesantis, thanks!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @aldesantis!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants