Upgrade to CircleCI 2.1 #3253
Merged
Upgrade to CircleCI 2.1 #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Jul 5, 2019
| @@ -27,7 +27,7 @@ jobs: | |||
| - run: | | |||
| bundle install --path=vendor/bundle | |||
|
|
|||
| - cache-save: | |||
| - save_cache: | |||
There was a problem hiding this comment.
I'm sure there's a valid reason but can you explain this change better in the commit message, please?
There was a problem hiding this comment.
@kennyadsl cache-save is not a valid step name in CircleCI, I'm actually not sure how this has worked so far. The right name is save_cache.
There was a problem hiding this comment.
😱
I'm also noticing that we are trying to restore the key solidus-gems-v1, which is never saved...
There was a problem hiding this comment.
@kennyadsl that's actually fine, because it will look for any keys that start with solidus-gems-v1.
There was a problem hiding this comment.
Found some reference about the cache-save step, maybe it's the CircleCI legacy way of calling that type of jobs.
jacobherrington
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to CircleCI 2.1, which allows us to use Orbs. This is especially important for #3252, since we want to use this Orb for keeping the OAS documentation in sync with Stoplight.
Checklist: