Use i18n for datepicker format

[coorasse]

This PR fixes #2721.
I'd like to fix it already in version 2.7 and release a 2.7.4 if possible.
The datepicker should take the js_format from i18n file (not in use anywhere else).
I'll open also a PR on solidus_i18n to set it already correctly for the other locales.

I am not sure if this is a breaking change. If someone has overridden js_format with something weird it will probably stop working.

[kennyadsl]

Thanks, @coorasse. I'm rerunning specs, failures do not seem related but I did never see those before. Let's see what happens.

[aldesantis]

@coorasse we're going through old PRs and this seems like a fix we want to have. Unfortunately, 2.7 is not maintained anymore, so I don't know if it makes sense to add it there. If you still have the time, would you be willing to rebase against master or 2.8?

[kennyadsl]

For reference, if this is still valid, we should make this PR against master (and eventually backport).

[kennyadsl]

@coorasse I rebased this against master and resolved a conflict. If specs pass, I'll go head and add the backport labels to have this on recent support versions of Solidus and will ask for a review by other core team members. Thanks again!

[codecov]

Codecov Report

Merging #3321 (042ea36) into master (9757964) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3321   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files         578      578           
  Lines       14673    14673           
=======================================
  Hits        12721    12721           
  Misses       1952     1952           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kennyadsl]

@waiting-for-dev do you have any idea about why ensure and triage actions have not been triggered here? 🤔

[waiting-for-dev]

@waiting-for-dev do you have any idea about why ensure and triage actions have not been triggered here? 🤔

@kennyadsl, I think the synchronize activity type doesn't include changing the base branch. However, making a change to the commits on the head branch does. I forced another push and the workflow has run now.