Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js_format for datepicker #163

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fix js_format for datepicker #163

merged 1 commit into from
Oct 7, 2019

Conversation

coorasse
Copy link
Collaborator

@coorasse coorasse commented Aug 30, 2019 •
edited
Loading

These are the correct translations for solidusio/solidus#3321.
I removed all the empty values

kennyadsl
kennyadsl approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @coorasse! This can be merged even before solidusio/solidus#3321, right?

jacobherrington
jacobherrington approved these changes Sep 3, 2019
View reviewed changes
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@delphaber
Copy link

I'll update my PR (#162) with this :)

@spaghetticode
Copy link
Member

@coorasse unfortunately, this has some conflicts now... can you please rebase with master?

@coorasse
Copy link
Collaborator Author

coorasse commented Oct 7, 2019

NP. Done.

spaghetticode
spaghetticode approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coorasse thank you 👍

@spaghetticode spaghetticode merged commit 1af1b82 into master Oct 7, 2019
@kennyadsl kennyadsl deleted the fix_datepicker_js_option branch February 3, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coorasse @delphaber @spaghetticode @kennyadsl @jacobherrington