Revert "Deprecate callback setting variant price from master" #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we've decided to put the greater goal behind this change (inheriting all prices from master when creating variants) on hold. The reason for that is that we have higher priorities and that we'll revisit refactoring core logic when we implement more events or services on Solidus. As the reverted commit raised a deprecation warning, it's better to wait until we have a clearer direction in mind.
gmacdougall
approved these changes
Jul 14, 2021
spaghetticode
approved these changes
Jul 14, 2021
jarednorman
approved these changes
Jul 14, 2021
kennyadsl
deleted the
waiting_for_dev/revert_deprecate_callback_setting_variant_price_from_master
branch
5 tasks
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Sep 10, 2021
The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl))
kennyadsl
pushed a commit
that referenced
this pull request
Sep 10, 2021
* Prepare CHANGELOG for Solidus 3.1 release The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [#4140](#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [#4132](#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [#4078](#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [#4100](#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [#4119](#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [#4033](#4033) ([kennyadsl](https://github.com/kennyadsl)) * Add backported entries
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
* Prepare CHANGELOG for Solidus 3.1 release The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl)) * Add backported entries
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
* Prepare CHANGELOG for Solidus 3.1 release The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl)) * Add backported entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4078
For now, we've decided to put the greater goal behind this change
(inheriting all prices from master when creating variants) on hold. The
reason for that is that we have higher priorities and that we'll revisit
refactoring core logic when we implement more events or services on
Solidus.
As the reverted commit raised a deprecation warning, it's better to wait until
we have a clearer direction in mind.