Prepare CHANGELOG for Solidus 3.1 release #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
force-pushed
the
waiting-for-dev/changelog_for_3_1
branch
3 times, most recently
from
5515a58 to
33bc3d4
Compare
5 tasks
|
Added a couple of commit:
|
waiting-for-dev
force-pushed
the
waiting-for-dev/changelog_for_3_1
branch
from
2853653 to
9d9b90a
Compare
kennyadsl
reviewed
Sep 6, 2021
| `Spree::Price#amount` field can no longer be `nil`. Besides adding the | ||
| validation at the model layer, we ship with a task that will remove records | ||
| where the amount is `NULL` in the database. You should run the task before | ||
| executing the new migrations: |
There was a problem hiding this comment.
I see some problems here when deploying these changes to staging/production. The script should be run before migrations but usually migrations are executed automatically on deploy. I think the only way to solve this is by suggesting people to copy/paste the rake task in their application and run it before deploying the upgrade. Do you any other ideas?
There was a problem hiding this comment.
That's definitely a good point. Yes, they could copy it into their own task or enter the console and manually executing it (which is always dangerous in production). I see no other way. Because we could add the task into the database migration itself, but I don't think it's safe to delete user records blindly without making them knowledgeable of it.
I added a new commit with the additional notes. Please, take a look. The link to the task won't work because it's waiting for #4157 to be merged.
The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl))
waiting-for-dev
force-pushed
the
waiting-for-dev/changelog_for_3_1
branch
from
3527009 to
a3703cf
Compare
|
Added lastest entries, squashed commits and rebased from master. |
waiting-for-dev
force-pushed
the
waiting-for-dev/changelog_for_3_1
branch
from
5672095 to
01c96ea
Compare
|
Going to merge this without approvals because it's a release task. |
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
* Prepare CHANGELOG for Solidus 3.1 release The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl)) * Add backported entries
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
* Prepare CHANGELOG for Solidus 3.1 release The new entries have been generated through the following command, as detailed in the [how-to-release guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date): ```bash git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus ``` The following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff: - Docker: Change public keys server after deprecation [solidusio#4140](solidusio#4140) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Revert "Deprecate callback setting variant price from master" [solidusio#4132](solidusio#4132) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Deprecate callback setting variant price from master [solidusio#4078](solidusio#4078) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Remove staled comment [solidusio#4100](solidusio#4100) ([waiting-for-dev](https://github.com/waiting-for-dev)) - Disable perform_caching in DummyApp [solidusio#4119](solidusio#4119) ([gsmendoza](https://github.com/gsmendoza)) - Master now tracks 3.1.0 [solidusio#4033](solidusio#4033) ([kennyadsl](https://github.com/kennyadsl)) * Add backported entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepare CHANGELOG for Solidus 3.1 release
The new entries have been generated through the following command, as detailed in the how-to-release guides:
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidusThe following items have been removed because of being change/revert pairs or being changes on top of still-unreleased stuff:
Checklist: