Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OrderWalkThrough to take a user #4292

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 4, 2022

The OrderWalkThrough creates an order that can't be completed because
the credit card associated with the order has a different user (some
user) than the order it's being associated to (nil). This leads to
failures on trying to add that credit card to the user's wallet.

Checklist:

The OrderWalkThrough creates an order that can't be completed because
the credit card associated with the order has a different user (some
user) than the order it's being associated to (nil). This leads to
failures on trying to add that credit card to the user's wallet.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you.

@waiting-for-dev waiting-for-dev merged commit 6a91bd3 into solidusio:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants