-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action to automatically create backport PRs #4678
GitHub Action to automatically create backport PRs #4678
Conversation
This commit integrates the backport-github-action [1] GitHub Action. It automatically creates PRs for the branches specified via labels on another PR. For instance, if a PR to master has the following labels: - Needs Backport - Needs Backport-v3.2 - Needs Backport-v3.1 It'll create two other PRs, cherry-picking the commits on v3.2 and v3.1 branches. The action is triggered whenever: - A PR with those labels is merged - A closed PR has those labels added After the action runs, the "parent" PR is updated with a status report, informing of any encountered error (e.g., merge conflicts). We've chosen this action over the Backporting [2] action because the former has support for PRs containing multiple commits, which corresponds to our current flow. At the same time, the latter only works with single-commit PRs. 1 - https://github.com/sqren/backport-github-action 2 - https://github.com/marketplace/actions/backporting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @waiting-for-dev , this is super cool!
This is 💯 |
Summary
This commit integrates the backport-github-action GitHub Action.
It automatically creates PRs for the branches specified via labels on another PR. For instance, if a PR to master has the following labels:
It'll create two other PRs, cherry-picking the commits on v3.2 and v3.1 branches. The action is triggered whenever:
After the action runs, the "parent" PR is updated with a status report, informing of any encountered error (e.g., merge conflicts).
We've chosen this action over the Backporting action because the former has support for PRs containing multiple commits, which corresponds to our current flow. At the same time, the latter only works with single-commit PRs.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the readme to account for my changes.