[v3.2] Require mail >= 2.8.0.rc1 for Ruby 3.1 support #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.1 removed net-smtp, net-imap and net-pop from standardlib and extracted them into independent gems. The mail gem >= 2.8.0.rc1 added them to their dependencies. Since we require the mail gem in core.rb:17 we need to add the mail gem as dependency and need to make sure it is the Ruby 3.1 compatible version as we support Ruby 3.1
tvdeyen
force-pushed
the
3.2-ruby-3.1-fixes
branch
from
931e2fb to
0ef7a78
Compare
tvdeyen
changed the title
@kennyadsl wow! nice. Should I close this PR now? |
|
Yep, please see #4678. |
|
This is very helpful for contributors! ❤️ |
|
Maybe we should be more clear somehow that it's not required anymore (most of the times) to create these backport PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #4734 but for v3.2