[v3.2] Add webrick as explicit dev dependency #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We need webrick to run JS tests using Teaspoon. This dependency is no more bundled with latest ruby versions and won't be available unless explicitely added to the Gemfile. Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ Not sure why this started to pop now, maybe something with the ruby versions available in CircleCI. Anyway, it seems legit and we should do it. (cherry picked from commit 0f591e0)
github-actions
bot
force-pushed
the
backport/v3.2/pr-5010
branch
from
f02c35b to
0976c90
Compare
3 tasks
kennyadsl
changed the title
waiting-for-dev
added
the
changelog:repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertov3.2:Questions ?
Please refer to the Backport tool documentation