Add webrick as explicit dev dependency #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need webrick to run JS tests using Teaspoon. This dependency is no more bundled with latest ruby versions and won't be available unless explicitely added to the Gemfile. Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ Not sure why this started to pop now, maybe something with the ruby versions available in CircleCI. Anyway, it seems legit and we should do it.
github-actions
bot
added
the
changelog:repository
3 tasks
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need webrick to run JS tests using Teaspoon.
This dependency is no more bundled with latest ruby versions and won't be available unless explicitely added to the Gemfile.
Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Not sure why this started to pop now, maybe something with the ruby versions available in CircleCI. Anyway, it seems legit and we should do it.
This is an example of failing build: https://app.circleci.com/pipelines/github/nebulab/solidus/915/workflows/5865af00-dbdd-49f9-8bbb-d057f621a02f/jobs/13055
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: