Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.3] Add webrick as explicit dev dependency #5018

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from master to v3.3:

Questions ?

Please refer to the Backport tool documentation

We need webrick to run JS tests using Teaspoon.
This dependency is no more bundled with latest ruby versions
and won't be available unless explicitely added to the Gemfile.

Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

Not sure why this started to pop now, maybe something with the ruby
versions available in CircleCI. Anyway, it seems legit and we should do
it.

(cherry picked from commit 0f591e0)
@github-actions github-actions bot requested a review from a team as a code owner April 17, 2023 08:09
@kennyadsl kennyadsl changed the title [v3.3] Merge pull request #5010 from nebulab/kennyadsl/fix-teaspoon [v3.3] Add webrick as explicit dev dependency Apr 17, 2023
@waiting-for-dev waiting-for-dev added the changelog:repository Changes to the repository not within any gem label Apr 17, 2023
@kennyadsl kennyadsl merged commit 493e135 into v3.3 Apr 17, 2023
@kennyadsl kennyadsl deleted the backport/v3.3/pr-5010 branch April 17, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants