Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix selenium-webdriver version to avoid bug" #5082

Merged

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented May 22, 2023

Summary

This reverts commit f468994.

After the release of capybara 3.39.1 with a fix for the issue for the newest selenium-webdriver release, there's no longer the need to lock the later.

See:

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

This reverts commit f468994.

After the release of capybara 3.39.1 with a fix for the issue for the
newest selenium-webdriver release, there's no longer the need to lock
the later.

See:

- teamcapybara/capybara#2667
- teamcapybara/capybara#2666
- SeleniumHQ/selenium#12005
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label May 22, 2023
@waiting-for-dev waiting-for-dev self-assigned this May 22, 2023
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner May 22, 2023 03:42
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label May 22, 2023
@waiting-for-dev waiting-for-dev merged commit 8438947 into solidusio:main May 23, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/revert_ci_fix branch May 23, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants