selenium log suppression: forward both positional and keyword args #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3 separated positional and keyword arguments, which changes the way we need to forward them. Just using `*` isn't enough. We either need to use `...` or handle both positional and keyword. Use the latter approach here since it's compatible with the most Ruby versions. Fix teamcapybara#2666 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
May 10, 2023
Until teamcapybara/capybara#2667 got released
kyrofa
commented
May 10, 2023
| @@ -3,7 +3,7 @@ | |||
| module Capybara | |||
| module Selenium | |||
| module DeprecationSuppressor | |||
| def initialize(*, **) | |||
| def initialize(...) | |||
There was a problem hiding this comment.
I was about to point out that this is incompatible with Ruby 2.5, but then I took a closer look at the gemspec and saw the required_ruby_version 😛 . I'm sorry, I should have done it this way from the beginning. Thanks for covering for me.
waiting-for-dev
pushed a commit
to waiting-for-dev/capybara
that referenced
this pull request
May 12, 2023
…eamcapybara#2667) * selenium log suppression: forward all parameters passed (cherry-picked from 43e32a8)
twalpole
pushed a commit
that referenced
this pull request
May 12, 2023
…2667) * selenium log suppression: forward all parameters passed
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
May 18, 2023
Until teamcapybara/capybara#2667 got released
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
May 22, 2023
This reverts commit f468994. After the release of capybara 3.39.1 with a fix for the issue for the newest selenium-webdriver release, there's no longer the need to lock the later. See: - teamcapybara/capybara#2667 - teamcapybara/capybara#2666 - SeleniumHQ/selenium#12005
3 tasks
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
May 22, 2023
This reverts commit 9224baf. After the release of capybara 3.39.1 with a fix for the issue for the newest selenium-webdriver release, there's no longer the need to lock the later. See: - teamcapybara/capybara#2667 - teamcapybara/capybara#2666 - SeleniumHQ/selenium#12005
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3 separated positional and keyword arguments, which changes the way we need to forward them. Just using
*isn't enough, as exposed by #2666. We either need to use...or handle both positional and keyword. We opt for the latter approach here since it's compatible with the most Ruby versions.