Fix spec failures due to missing address last_name #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice debugging. 👍 It's interesting that the ActiveMerchant name splitting code is intentionally that way as per the specs. I wonder what the "right" thing to do is. I suppose this is another indication that we should move toward a single name field like we discussed in solidusio/solidus#1369. |
jordan-brough
approved these changes
Oct 5, 2016
gsmendoza
pushed a commit
to gsmendoza/solidus_braintree
that referenced
this pull request
Dec 28, 2022
Adds '\n' to the routes.rb addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.