System specs support #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocknotes
force-pushed
the
mr/system-specs-support
branch
from
264c152 to
42e4b7f
Compare
lib/solidus_dev_support/templates/extension/spec/spec_helper.rb.tt
Outdated
Show resolved
Hide resolved
blocknotes
force-pushed
the
mr/system-specs-support
branch
2 times, most recently
from
0e62a41 to
87d9b59
Compare
This will permit to use methods like `stub_authorization!` in system specs. Only for Solidus < 2.11, because another PR is going to update the system specs configuration on the next releases.
blocknotes
force-pushed
the
mr/system-specs-support
branch
from
87d9b59 to
e313040
Compare
kennyadsl
reviewed
Apr 20, 2020
|
|
||
| config.when_first_matching_example_defined(type: :system) do | ||
| config.before :suite do | ||
| dev_support_assets_preload |
There was a problem hiding this comment.
What about using https://github.com/solidusio/solidus/blob/138bf619647b125a53c8898fce6d01a9dee2c7a2/core/lib/spree/testing_support/precompiled_assets.rb for Solidus >= 2.11?
|
Hi @blocknotes, love this! Let me know if you need any help here to move this in. Thanks! |
I didn't have a chance to work more on this one, sorry. @peterberkenbosch feel free to contribute if you can/like. |
|
@blocknotes No problem Mattia, I can take this on no problem. |
3 tasks
|
Working on this here #107 we can close this one. Thanks again for starting this @blocknotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes small improvements to support system specs.
Checklist