Fix the CI #145
Merged
Fix the CI #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/fix-ci
branch
from
8932225 to
33cf10e
Compare
|
I still couldn't figure out what happens with specs here. My initial investigation showed that for some specs, the Also, we have the same exact tests in solidus_frontend and they work correctly. 🤔 |
kennyadsl
force-pushed
the
kennyadsl/fix-ci
branch
from
63f5c7a to
68b2a65
Compare
This was referenced Mar 1, 2021
kennyadsl
force-pushed
the
kennyadsl/fix-ci
branch
from
85b3afe to
68b2a65
Compare
kennyadsl
force-pushed
the
kennyadsl/fix-ci
branch
from
68b2a65 to
3a8c580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solidus master now tracks 3.0 and we are testing this gem against it. Almost all the deprecated code was removed but there was still something.