Update test to use discard instead of paranoia

[waiting-for-dev]

Ref solidusio/solidus@b0092d0f3

Description

The Master branch on solidus is not using paranoia anymore, so we need to update from our end.

It wasn't caught by the CI because, if I'm not wrong, it's using released solidus versions.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[kennyadsl]

@waiting-for-dev I think this commit is already in #145. I know that @SamuelMartini also did find why the remaining specs are failing. @SamuelMartini can you please report here or in #145 what you discovered?

[SamuelMartini]

@waiting-for-dev I think this commit is already in #145. I know that @SamuelMartini also did find why the remaining specs are failing. @SamuelMartini can you please report here or in #145 what you discovered?

The error I'm referring to is

NoMethodError:
  undefined method `name' for nil:NilClass

That currently happens in spec/system/products_spec.rb:164 and /spec/system/products_spec.rb:198.
This is rails trying to detect the active storage service name
which is not set in the dummy app the tests are using.

There are 2 dummy apps that solidus can create:

1. Dummy::Application to test extensions that use this DummyGenerator#test_dummy_config. This generator creates a full rails application (Dummy::Application) also used by solidus_starter_frontend.
2. DummyApp::Application to test the solidus framework and it is an application initialized in-memory here.

This commit configures the active storage for the solidus DummyApp::Application(2).

We need to add a similar configuration to the DummyGenerator(1) so that extensions(and solidus_starter_frontend) that run on solidus 3 have the service set.

[waiting-for-dev]

Then, probably this PR can be closed 🙂