Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandbox generation #196

Closed
luca-landa opened this issue Feb 5, 2021 · 3 comments · Fixed by #197
Closed

Fix sandbox generation #196

luca-landa opened this issue Feb 5, 2021 · 3 comments · Fixed by #197
Assignees

Comments

@luca-landa
Copy link
Contributor

After creating a sandbox, the store is not mounted in config.rb and the migrations aren't copied and executed entirely.

There's this error in the process: Could not find generator 'spree:install'.

Currently, the Solidus sandbox generation is working, so it may be a problem with a specific dependency of this gem.

@blocknotes blocknotes self-assigned this Feb 5, 2021
@blocknotes
Copy link
Contributor

I'm doing some investigations here.

  • I tried to move back to a commit of 1 month ago to check if we have a regression, but the problem looks the same - so It could be related to something wrong with an external dependency;
  • after cloning the repo and running bin/rails-sandbox at some point I see a Could not find generator 'spree:install'.:
Dropped database 'db/development.sqlite3'
Database 'db/test.sqlite3' does not exist
Created database 'db/development.sqlite3'
Created database 'db/test.sqlite3'
Could not find generator 'spree:install'.
Run `bin/rails generate --help` for more options.
      create  config/initializers/devise.rb
         run  bundle exec rake railties:install:migrations FROM=solidus_auth from "."

@blocknotes
Copy link
Contributor

blocknotes commented Feb 5, 2021

It looks like that the issue is related to the change from spree:install to solidus:install (solidusio/solidus#3538) - but I'm still tracking down better what happened here.

Updating the spree:install line in bin/sandbox seems to solve the problem.

@blocknotes
Copy link
Contributor

solidus:install should be available with the next release of solidus_dev_support.
When this happens we will need to run solidus extension . to apply the change to our bin/sandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants