Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spree:install to solidus:install in the sandbox template #167

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Rename spree:install to solidus:install in the sandbox template #167

merged 1 commit into from
Feb 5, 2021

Conversation

blocknotes
Copy link
Contributor

@blocknotes blocknotes commented Feb 5, 2021

spree:install task have been renamed to solidus:install (reference solidusio/solidus#3538)

We had an issue while creating new sandboxes with solidus_subscriptions extension (ref: solidusio/solidus_subscriptions#196).

Tests

  • I uninstalled previous versions of solidus_dev_support from my system
  • I installed solidus_dev_support from this PR branch
  • I executed solidus extension . in solidus_dev_support project to update bin/sandbox
  • I recreated the sandbox using bin/rails-sandbox

Result:

  • The "Could not find generator 'spree:install'." error line is gone

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2021

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Feb 5, 2021
@blocknotes blocknotes marked this pull request as ready for review February 5, 2021 13:10
@kennyadsl kennyadsl merged commit 32e868c into solidusio:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog label Needs a label to determine the type of change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants