-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the installation generator to solidus:install #3538
Conversation
With this change we can provide a better experience to first-time users and avoid some confusion in the initial steps of onboarding. This is not a breaking change since the install process is done only when installing Solidus and existing users won't re-run this command again.
This allows the old generator to continue working and it will print a deprecation warning at the end of the process to inform users that they need to switch to the new generator. I think that currently this is only used into other extensions or support gems, like solidus_dev_support.
f670032
to
854e51c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennyadsl thanks!
I'm using Here is my config. I just init a Rails app and put
Here is my
Ruby and Rails version
Generators I have(looks like it still uses the old one)
|
Hey there, for solidus <= 2.10 the generator is called |
Description
With this change, we can provide a better experience to first-time users and avoid some confusion in the initial steps of onboarding.
This is not a breaking change since the install process is done only when installing Solidus and existing users won't re-run this command again. Also, the old generator has been kept, and it prints a deprecation warning if ran.
Checklist:
[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)