-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple ImagePullSecrets #575
Conversation
Issues linked to changelog: |
71072f5
to
737b43d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we open a draft against GME where you generate the chart against this locally? Then you could verify the templating is correct there.
{{- if $[[ $operatorVar ]].imagePullSecrets }} | ||
{{- $pullSecrets = concat $pullSecrets $[[ $operatorVar ]].imagePullSecrets -}} | ||
{{- end }} | ||
{{- (dict "imagePullSecrets" $pullSecrets) | toYaml | nindent 6 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is going to render right, imagePullSecrets is an array not a dict. Maybe something like this?
{{- (dict "imagePullSecrets" $pullSecrets) | toYaml | nindent 6 }} | |
{{- if gt (len $pullSecrets) 0 -}} | |
imagePullSecrets: | |
{{- toYaml $pullSecrets | nindent 8 }} | |
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if the indent is right
Add support for multiple image pull secrets
Manual Helm Testing
BOT NOTES:
resolves #574