Fix the rootdir in the nouse_install.yml #273
Conversation
| @@ -83,7 +83,7 @@ jobs: | |||
| python3 -c 'import os; print(os.getcwd())' | |||
| python3 -c "import modmesh; print(modmesh.__file__)" | |||
| python3 -c "import _modmesh; print(_modmesh.__file__)" | |||
| pytest --rootdir=/tmp -v | |||
| pytest --rootdir=. -v | |||
There was a problem hiding this comment.
Please keep the original code in a comment and add a link to the root cause. When the bug in pytest is fixed we can change it back.
There was a problem hiding this comment.
Thank you for your suggestions.
I write the comments, including the issue and the original code.
| @@ -166,5 +166,5 @@ jobs: | |||
| python3 -c 'import os; print(os.getcwd())' | |||
| python3 -c "import modmesh; print(modmesh.__file__)" | |||
| python3 -c "import _modmesh; print(_modmesh.__file__)" | |||
| pytest --rootdir=/tmp -v | |||
| pytest --rootdir=. -v | |||
.github/workflows/nouse_install.yml
Outdated
| ### The following command is the original commend, and it will fail on pytest == 8.0.0 . | ||
| ### pytest --rootdir=/tmp -v | ||
| ### Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781 | ||
| ### The alternative command to solve the issue is ```pytest --rootdir=. -v```. | ||
| pytest --rootdir=. -v |
There was a problem hiding this comment.
I add the comment, including the original command, the modified command, and the source of the issue and solutions.
There was a problem hiding this comment.
Thanks, the messages are clear. Could you please follow the comment style to use a single # symbol?
There was a problem hiding this comment.
Thanks, the messages are clear. Could you please follow the comment style to use a single
#symbol?
@yungyuc No problem, I modify the inconsistent part and push the modification to the branch.
.github/workflows/nouse_install.yml
Outdated
| ### The following command is the original commend, and it will fail on pytest == 8.0.0 . | ||
| ### pytest --rootdir=/tmp -v | ||
| ### Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781 | ||
| ### The alternative command to solve the issue is ```pytest --rootdir=. -v``` . | ||
| pytest --rootdir=. -v |
There was a problem hiding this comment.
I also add the comment here.
In order to unify the coding style, I modify the comment for 1 #.
| # The following command is the original commend, and it will fail on pytest == 8.0.0 . | ||
| # pytest --rootdir=/tmp -v | ||
| # Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781 | ||
| # The alternative command to solve the issue is ```pytest --rootdir=. -v```. |
There was a problem hiding this comment.
I modify the number of # to keep the consistent coding style.
| # The following command is the original commend, and it will fail on pytest == 8.0.0 . | ||
| # pytest --rootdir=/tmp -v | ||
| # Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781 | ||
| # The alternative command to solve the issue is ```pytest --rootdir=. -v``` . |
There was a problem hiding this comment.
I modify the number of # to keep the consistent coding style.
|
Thanks @ThreeMonth03 for working around the pytest issue (pytest-dev/pytest#11781) |
Work around the pytest issue pytest-dev/pytest#11781 by replacing `pytest rootdir=./tmp -v` with `pytest rootdir=. -v` Co-authored-by: ThreeMonth03 <sankagetsu.cs08@nycu.edu.tw>
Modify
pytest --rootdir=/tmp -vtopytest --rootdir=. -v.