Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the rootdir in the nouse_install.yml #273

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Fix the rootdir in the nouse_install.yml #273

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2436d65
try to fix the bug: pytest rootdir=./tmp -v
Jan 31, 2024
2e486b0
try to fix the bug: pytest rootdir=./tmp -v
Jan 31, 2024
dde4b47
try to fix the bug in the nouse_install: pytest rootdir=./tmp -v
Jan 31, 2024
f6b253f
try to fix the bug in the nouse_install: pytest rootdir=. -v
Jan 31, 2024
14f85e7
Add the comment about the temporary modification.
ThreeMonth03 Jan 31, 2024
afdcc3b
Modify the comment about the modification.
ThreeMonth03 Jan 31, 2024
1105d2e
Merge pull request #1 from ThreeMonth03/progress
ThreeMonth03 Jan 31, 2024
53302a2
In order to unify the coding style, I modify the comment for 1 #.
ThreeMonth03 Feb 1, 2024
27d4384
Merge pull request #2 from ThreeMonth03/progress
ThreeMonth03 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/nouse_install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ jobs:
python3 -c 'import os; print(os.getcwd())'
python3 -c "import modmesh; print(modmesh.__file__)"
python3 -c "import _modmesh; print(_modmesh.__file__)"
pytest --rootdir=/tmp -v
# The following command is the original commend, and it will fail on pytest == 8.0.0 .
# pytest --rootdir=/tmp -v
# Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781
# The alternative command to solve the issue is ```pytest --rootdir=. -v```.
Comment on lines +86 to +89
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modify the number of # to keep the consistent coding style.

pytest --rootdir=. -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the original code in a comment and add a link to the root cause. When the bug in pytest is fixed we can change it back.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions.
I write the comments, including the issue and the original code.

cd ..

nouse_install_macos:
Expand Down Expand Up @@ -166,5 +170,9 @@ jobs:
python3 -c 'import os; print(os.getcwd())'
python3 -c "import modmesh; print(modmesh.__file__)"
python3 -c "import _modmesh; print(_modmesh.__file__)"
pytest --rootdir=/tmp -v
# The following command is the original commend, and it will fail on pytest == 8.0.0 .
# pytest --rootdir=/tmp -v
# Here is the issue and temporary solution: https://github.com/pytest-dev/pytest/issues/11781
# The alternative command to solve the issue is ```pytest --rootdir=. -v``` .
Comment on lines +173 to +176
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modify the number of # to keep the consistent coding style.

pytest --rootdir=. -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change both places.

cd ..
Loading