Implemented test suite for widget rendering #275

core23 · 2016-05-28T06:57:21Z

Changelog

### Added
- Added `AbstractWidgetTestCase` test suite

Subject

Added a test suite for widget rendering. Basically it's a port of https://github.com/sonata-project/SonataAdminBundle/blob/3.x/Tests/Form/Widget/BaseWidgetTest.php to have a test suite for all bundles.

This can be used for sonata-project/SonataFormatterBundle#146

OskarStark · 2016-05-28T18:25:59Z

Tests/Form/Widget/BaseWidgetTest.php

+
+/**
+ * Class BaseWidgetTest.
+ */


@author tag is missing

OskarStark · 2016-05-28T18:26:59Z

LGTM 👍

@greg0ire can you give us a final review please?

greg0ire · 2016-05-28T19:19:17Z

Tests/Form/Widget/BaseWidgetTest.php

+    /**
+     * {@inheritdoc}
+     */
+    public function setUp()


Should be protected

greg0ire · 2016-06-01T08:36:29Z

Tests/Form/Widget/BaseWidgetTest.php

+ *
+ * @author Christian Gripp <mail@core23.de>
+ */
+abstract class BaseWidgetTest extends TypeTestCase


See sonata-project/dev-kit#116

soullivaneuh · 2016-06-02T12:19:21Z

Please wait sonata-project/dev-kit#116 (comment) decision before merge.

OskarStark · 2016-06-15T10:24:36Z

@core23 we have a decision, can you please check if this PR fullfill this?

core23 · 2016-06-15T15:33:03Z

Don't know what's missing.

greg0ire · 2016-06-17T10:41:09Z

Test/Form/Widget/AbstractWidgetTestCase.php

+            __DIR__.'/../../../vendor/symfony/twig-bridge/Symfony/Bridge/Twig/Resources/views/Form',
+            __DIR__.'/../../../vendor/symfony/twig-bridge/Resources/views/Form',
+            __DIR__.'/../../../vendor/symfony/symfony/src/Symfony/Bridge/Twig/Resources/views/Form',
+            __DIR__.'/../../../../../symfony/symfony/src/Symfony/Bridge/Twig/Resources/views/Form',


Please document each line, explaining in which situation each can happen. If you don't know, simply remove the line, and it will be added later with a comment if really needed. BTW, I don't think running tests from a Symfony project should be supported.

soullivaneuh · 2016-06-17T11:22:28Z

A test case should have documentation of how to use it.

soullivaneuh · 2016-06-17T11:23:10Z

BTW, a test that meant to be publicly used should be tested as well. Or at lest implemented on this bundle for code coverage.

greg0ire · 2016-06-17T12:44:42Z

BTW, a test that meant to be publicly used should be tested as well. Or at lest implemented on this bundle for code coverage.

Testception :)

core23 · 2016-07-03T15:41:50Z

Added NEXT_MAJOR notes for symfony BC hacks. Hope everything is fine now 👍

core23 · 2016-07-14T17:03:46Z

Added a new Test chapter to the documentation.

core23 · 2016-07-21T17:26:06Z

RTM?

core23 · 2016-07-28T17:41:49Z

Ping @soullivaneuh @greg0ire

core23 · 2016-08-09T14:47:12Z

Can you give a final review @soullivaneuh @greg0ire

greg0ire · 2016-08-09T14:52:03Z

Tests/Form/Type/FormChoiceWidgetTest.php

+        $html = $this->renderWidget($choice->createView());
+
+        $this->assertContains(
+            '<div id="choice"><input type="checkbox" id="choice_0" name="choice[]" value="0" /><label for="choice_0">[trans]some[/trans]</label><input type="checkbox" id="choice_1" name="choice[]" value="1" /><label for="choice_1">[trans]choices[/trans]</label></div>',


Use line breaks here please :

<?php $this->cleanHtmlWhitespace(<<<HTML <div id="choice"> <input type="checkbox" id="choice_0" name="choice[]" value="0" /> <label for="choice_0">[trans]some[/trans]</label> <input type="checkbox" id="choice_1" name="choice[]" value="1" /> <label for="choice_1">[trans]choices[/trans]</label> </div> HTML)

OskarStark · 2016-08-12T08:56:42Z

@core23 can you please check travis?

core23 · 2016-08-15T16:29:29Z

All green :)

greg0ire · 2016-08-15T16:33:23Z

LGTM

OskarStark · 2016-08-16T07:26:44Z

Thank you @core23 👍

core23 added the minor label May 28, 2016

SonataCI added the review required label May 28, 2016

OskarStark reviewed May 28, 2016
View reviewed changes

Tests/Form/Widget/BaseWidgetTest.php

/**

* Class BaseWidgetTest.

*/

Copy link

Member

OskarStark May 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@author tag is missing

greg0ire reviewed May 28, 2016
View reviewed changes

Tests/Form/Widget/BaseWidgetTest.php

/**

* {@inheritdoc}

*/

public function setUp()

Copy link

Contributor

greg0ire May 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be protected

core23 force-pushed the widget-test branch 4 times, most recently from a141da5 to 2285fed Compare May 30, 2016 15:54

greg0ire reviewed Jun 1, 2016
View reviewed changes

core23 force-pushed the widget-test branch from 2285fed to 12aa525 Compare June 1, 2016 15:05

core23 force-pushed the widget-test branch from 12aa525 to b904a0c Compare June 3, 2016 16:10

greg0ire reviewed Jun 17, 2016
View reviewed changes

soullivaneuh added the Needs: Documentation label Jun 17, 2016

soullivaneuh added the Needs: Tests label Jun 17, 2016

core23 force-pushed the widget-test branch 2 times, most recently from 1608b2e to 3fb5734 Compare June 17, 2016 13:52

SonataCI removed the pending author label Jun 20, 2016

core23 force-pushed the widget-test branch from 49c5400 to 08bd5ff Compare July 3, 2016 15:41

core23 force-pushed the widget-test branch from 08bd5ff to 53401b4 Compare July 14, 2016 17:02

core23 removed the Needs: Documentation label Jul 14, 2016

core23 force-pushed the widget-test branch from 53401b4 to 7fd294d Compare July 14, 2016 17:30

core23 force-pushed the widget-test branch 4 times, most recently from 2f71a2c to ff3b770 Compare July 28, 2016 17:00

core23 force-pushed the widget-test branch from ff3b770 to 2d0db19 Compare July 29, 2016 16:49

greg0ire reviewed Aug 9, 2016
View reviewed changes

core23 force-pushed the widget-test branch from 2d0db19 to d7b9221 Compare August 9, 2016 15:20

greg0ire mentioned this pull request Aug 9, 2016

Make abstract test case for user sonata-project/dev-kit#116

Closed

OskarStark added the pending author label Aug 12, 2016

Implemented test suite for widget rendering

a157109

core23 force-pushed the widget-test branch from d7b9221 to a157109 Compare August 12, 2016 17:09

SonataCI removed the pending author label Aug 12, 2016

OskarStark removed the review required label Aug 16, 2016

OskarStark merged commit 5224529 into sonata-project:3.x Aug 16, 2016

core23 deleted the widget-test branch August 16, 2016 08:17

core23 mentioned this pull request Aug 17, 2016

Optimized WidgetTestCase #335

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented test suite for widget rendering #275

Implemented test suite for widget rendering #275

core23 commented May 28, 2016 •

edited

Loading

OskarStark May 28, 2016

OskarStark commented May 28, 2016

greg0ire May 28, 2016

greg0ire Jun 1, 2016

soullivaneuh commented Jun 2, 2016

OskarStark commented Jun 15, 2016

core23 commented Jun 15, 2016

greg0ire Jun 17, 2016

soullivaneuh commented Jun 17, 2016

soullivaneuh commented Jun 17, 2016

greg0ire commented Jun 17, 2016

core23 commented Jul 3, 2016

core23 commented Jul 14, 2016 •

edited

Loading

core23 commented Jul 21, 2016

core23 commented Jul 28, 2016

core23 commented Aug 9, 2016

greg0ire Aug 9, 2016 •

edited

Loading

core23 Aug 9, 2016

OskarStark commented Aug 12, 2016

core23 commented Aug 15, 2016

greg0ire commented Aug 15, 2016

OskarStark commented Aug 16, 2016

Implemented test suite for widget rendering #275

Implemented test suite for widget rendering #275

Conversation

core23 commented May 28, 2016 • edited Loading

Changelog

Subject

OskarStark May 28, 2016

Choose a reason for hiding this comment

OskarStark commented May 28, 2016

greg0ire May 28, 2016

Choose a reason for hiding this comment

greg0ire Jun 1, 2016

Choose a reason for hiding this comment

soullivaneuh commented Jun 2, 2016

OskarStark commented Jun 15, 2016

core23 commented Jun 15, 2016

greg0ire Jun 17, 2016

Choose a reason for hiding this comment

soullivaneuh commented Jun 17, 2016

soullivaneuh commented Jun 17, 2016

greg0ire commented Jun 17, 2016

core23 commented Jul 3, 2016

core23 commented Jul 14, 2016 • edited Loading

core23 commented Jul 21, 2016

core23 commented Jul 28, 2016

core23 commented Aug 9, 2016

greg0ire Aug 9, 2016 • edited Loading

Choose a reason for hiding this comment

core23 Aug 9, 2016

Choose a reason for hiding this comment

OskarStark commented Aug 12, 2016

core23 commented Aug 15, 2016

greg0ire commented Aug 15, 2016

OskarStark commented Aug 16, 2016

core23 commented May 28, 2016 •

edited

Loading

core23 commented Jul 14, 2016 •

edited

Loading

greg0ire Aug 9, 2016 •

edited

Loading