FormatterType Support SF3

[rafaelcalleja]

add to #145 sonata_formatter_type support in SF3

[OskarStark]

LGTM

[greg0ire]

And the commit adds tests… great work!

[core23]

IMO, we don't need this

[dnoise]

done

[dnoise]

I've upgraded this PR with master because the Travis CI was failing but the upgrade doesn't fix the Test.

Thank to the failed test I guess have detected a issue about versions of egeloen/ckeditor-bundle from the last merge #110 .

Too In my project i can see:

The service "sonata.formatter.twig.ck_editor" has a dependency on a non-existent service "ivory_ck_editor.templating.helper".

The service ivory_ck_editor.templating.helper was renamed in version 2.4 but composer.json is allowing version 2.2
"egeloen/ckeditor-bundle": "^2.2|^3.0"

You can check it from this commit

To fix it and the test too simply need change composer.json to

"egeloen/ckeditor-bundle": "~2.4|^3.0",

maybe this change would be in a new PR or Issue?

[greg0ire]

maybe this change would be in a new PR or Issue?

I think it would. Can you do it? @Th3Mouk can you comment on this?

[dnoise]

The firt version of egeloen/ckeditor-bundle with support for symfony/form:~3.0 is 4.0

I guess we can support sf3 with something like this
"egeloen/ckeditor-bundle": "~2.4|^3.0|~4.0"

[Th3Mouk]

I've started to develop the upgrade in october and there's not 4.x releases, i agree that the composer.json must be upgrade from ^2.2 to ^2.5 because when i've tested i was in 2.5.2.

Il will make the upgrade of composer.

The ^4.0 upgrade seems really simple, @dnoise would you do the PR ?

[Th3Mouk]

I've check it's ok for 4.x support there no BC, i've made PR to #148

[OskarStark]

can we merge this @Th3Mouk ?

[Th3Mouk]

@OskarStark I can't pronounce on the testing part, that must be extract on a base class apparently.

@rafaelcalleja could you rebase please ? Tests are red actually

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[soullivaneuh]

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.