[WIP] Fixes for PHPCR-ODM #82
Conversation
| @@ -32,7 +32,9 @@ public function process(ContainerBuilder $container) | |||
| $definition = $container->getDefinition('sonata.core.model.adapter.chain'); | |||
|
|
|||
| if ($container->has('doctrine')) { | |||
| $definition->addMethodCall('addAdapter', array(new Reference('sonata.core.model.adapter.doctrine_orm'))); | |||
| if (class_exists('\Doctrine\ORM\Version')) { | |||
There was a problem hiding this comment.
the doctrine service is always present when the DoctrinePhpcrBundle is activated - but this does not mean the ORM is installed.
|
@rande Can you suggest any solutions for making the PHPCR-ODM "id's" work? i.e. last time I seem to recall that we made the routing requirements less strict to allow slashes in the ID. What do you think? |
|
@dantleech the issue with ids not working is in a PR sonata-project/SonataDoctrinePhpcrAdminBundle#284 |
|
I thought the problem here was with the Route requirements (at least thats the error I was confronting - maybe problem you mention is the one I would encounter next ....). I also wonder if we shouldn't just make the ID the UUID - that would make alot more sense and avoid potential future problem with same-name-siblings if that ever gets implemented in Jackalope. /cc @dbu |
|
the official ID for a phpcr-odm document is the path, not the uuid. so we should keep using that. same-name siblings would have a [2] and so on at the end. more important, not every document has a uuid, only when it is made referenceable. |
|
but we could encforce the UUID mapping on Sonata Media documents -- also UUIDs are not mutable and they don't contain slashes :) |
|
i merged sonata-project/SonataDoctrinePhpcrAdminBundle#284 - does this fix the issue here? |
|
@dbu: no, the error is:
I remember that when we had this before it was necessary to relax the requirement on the route object. Looking into it. |
|
Can one of the admins verify this patch? |
|
@dantleech Please rebase |
| } | ||
|
|
||
| $res = $this->modelAdapter->getUrlsafeIdentifier($model); | ||
| return $res; |
|
@dantleech is any of this still relevant? sonata admin does work these days without doctrine orm installed afaik. |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
This PR will hopefully succeed in getting the PHPCR-ODM implemntation working.
Todo: